Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize an access denied error when attempting to migrate an activestate.yaml. #3566

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Localize an access denied error when attempting to migrate an activestate.yaml. #3566

merged 2 commits into from
Oct 30, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 28, 2024 •
edited by github-actions bot
Loading

BugDX-3137 Rollbar: MUST ADDRESS: Error does not have localization: Could not parse projectfile

@mitchell-as mitchell-as requested a review from Naatan October 28, 2024 21:53
@mitchell-as mitchell-as marked this pull request as ready for review October 28, 2024 21:53
Naatan
Naatan requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should mark this an input error.

@mitchell-as
Copy link
Contributor Author

Good call.

@mitchell-as mitchell-as requested a review from Naatan October 30, 2024 17:07
@mitchell-as mitchell-as merged commit a7d4759 into version/0-47-0-RC1 Oct 30, 2024
8 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3137 branch October 30, 2024 17:19
as-builds added a commit that referenced this pull request Oct 30, 2024
@as-builds
Merge branch version/0-47-0-RC1 to adopt changes from PR #3566
d6acb39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @Naatan