Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed timestamp when asserting package versions. #3556

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Use fixed timestamp when asserting package versions. #3556

merged 1 commit into from
Oct 25, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 25, 2024 •
edited by github-actions bot
Loading

BugDX-3128 Nightly failure: TestPackageIntegrationTestSuite/TestChangeSummaryShowsAddedForUpdate

@mitchell-as mitchell-as changed the title Fix timestamp when asserting package versions. Use fixed timestamp when asserting package versions. Oct 25, 2024
@mitchell-as mitchell-as requested a review from MDrakos October 25, 2024 15:58
@mitchell-as mitchell-as marked this pull request as ready for review October 25, 2024 15:59
MDrakos
MDrakos approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better solution than constantly updating the dependency version 👍

@mitchell-as mitchell-as merged commit 64c0d72 into version/0-47-0-RC1 Oct 25, 2024
9 of 10 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-3128 branch October 25, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
Test: package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos