Re-enable CheckoutFromArchive test. #3554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-as
commented
Oct 23, 2024
Comment on lines
+49
to
+54
| internalIngredients := []*Ingredient{} | ||
| if os.Getenv(constants.InstallInternalDependenciesEnvVarName) != "true" { | ||
| internalIngredients = sliceutils.Filter(a.Ingredients, func(i *Ingredient) bool { | ||
| return i.Namespace == NamespaceInternal | ||
| }) | ||
| } |
There was a problem hiding this comment.
The checkout archive installs a shared/zlib package, which would be excluded by default. In order to keep things small and simple, add an env var override to avoid excluding internal packages.
mitchell-as
force-pushed
the
mitchell/dx-3057
branch
from
c9c0cc0 to
1cabf0e
Compare
Naatan
requested changes
Oct 23, 2024
There was a problem hiding this comment.
This doesn't feel appropriate to me. It seems the issue here is that this test was asserting something as installed which as it turns out shouldn't have been installed, that in itself was a bug that it seems we indirectly addressed at one point.
The solution here is to update the test code, we shouldn't need to introduce special logic in the buildplan for this. Can't we update the project we generate data from to use a real dependency that we can then assert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment here about how the test archives were originally constructed: https://activestatef.atlassian.net/browse/DX-3057?focusedCommentId=56035. They were not being mocked. It's real-world data.