Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test that verifies a bare state is not making any API calls. #3492

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Added test that verifies a bare state is not making any API calls. #3492

merged 1 commit into from
Sep 17, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Sep 17, 2024 •
edited by github-actions bot
Loading

TaskDX-2897 We have an integration test that checks for API requests on plain state tool invocations

@mitchell-as mitchell-as requested a review from MDrakos September 17, 2024 15:49
@mitchell-as mitchell-as marked this pull request as ready for review September 17, 2024 15:49
@mitchell-as
Copy link
Contributor Author

Test failures are unrelated to this PR.

I also did a local test with state pkg and it failed due to making an API call, so we're not deluding ourselves with a test that would never fail.

@mitchell-as mitchell-as reopened this Sep 17, 2024
@mitchell-as mitchell-as merged commit 42309b3 into version/0-47-0-RC1 Sep 17, 2024
17 of 23 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2897 branch September 17, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos