Do not validate commit ID from within projectfile. #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so prevents `state reset` from fixing a bad ID. Any runners that need a commit ID get it from localcommit, which raises an invalid commit ID error, so this validation is superfluous.
mitchell-as
force-pushed
the
mitchell/dx-3050
branch
from
d36b007 to
07fa246
Compare
Naatan
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
I don't like removing functionality to fix a bug. But I also see little value in the functionality being removed here. It wasn't a very friendly error for the user, and from what I can tell through the blame log this was introduced for headless commits, which we no longer have.
So accepting this one but beware of fixing bugs this way, more often than not this'd be an inappropriate fix.
|
I agree. I tried to fix this properly, but ran into a mountain of issues because project parsing was occurring so early in main.go. After going back to the drawing board, I came up with this solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so prevents
state resetfrom fixing a bad ID.Any runners that need a commit ID get it from localcommit, which raises an invalid commit ID error, so this validation is superfluous.