Add cycle support #3456
Merged
Add cycle support #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MDrakos
commented
Aug 20, 2024
•
MDrakos
commented
 DX-3002 Support cycles in the build plan
|
|
Looking at the test runs it appears to be known or intermittent failures. I've tested this locally with regular checkouts and PR deploy checkouts of Go projects. |
Naatan
requested changes
Aug 21, 2024
There was a problem hiding this comment.
I think we should also have a test covering the Dependencies() methods on both the Artifact and Ingredient type in the buildplan. I suspect these either need to also be cycle aware, or we'll need the test to prevent them regressing as it feels like a likely point for cycle bugs to happen.
| @@ -192,3 +192,75 @@ var buildWithRuntimeDepsViaSrc = &Build{ | |||
| }, | |||
| }, | |||
| } | |||
|
|
|||
| var buildWithRuntimeDepsViaSrcCycle = &Build{ | |||
There was a problem hiding this comment.
Could you please add a comment highlighting the cycle.
Naatan
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.