Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency output on state init #3452

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Fix dependency output on state init #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d597f50
Show all dependencies on
MDrakos Aug 16, 2024
325c0fb
Revert changes made my import formatter
MDrakos Aug 16, 2024
f732f7e
Update integration test
MDrakos Aug 16, 2024
13896e0
Remove expect
MDrakos Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/runners/initialize/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ func (r *Initialize) Run(params *RunParams) (rerr error) {
}
solveSpinner.Stop(locale.T("progress_success"))

dependencies.OutputSummary(r.out, commit.BuildPlan().RequestedArtifacts())
// When running `state init` we want to show all of the dependencies that will be installed.
dependencies.OutputSummary(r.out, commit.BuildPlan().Artifacts())
rti, err := runtime_runbit.Update(r.prime, trigger.TriggerInit, runtime_runbit.WithCommit(commit))
if err != nil {
return errs.Wrap(err, "Could not setup runtime after init")
Expand Down
3 changes: 1 addition & 2 deletions test/integration/init_int_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,7 @@ func (suite *InitIntegrationTestSuite) TestInit_ChangeSummary() {
cp.Expect("Done")
ts.NotifyProjectCreated(e2e.PersistentUsername, project)
cp.Expect("Setting up the following dependencies:")
cp.Expect("└─ [email protected]")
suite.Assert().NotContains(cp.Snapshot(), "├─", "more than one dependency was printed")
cp.Expect("├─ [email protected]")
cp.ExpectExitCode(0)
}

Expand Down
Loading