state import with SBOMs should still update the commit.
#3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect the solve to fail, but we should still update the commit so the user can see what was added, even if the runtime is no longer viable.
mitchell-as
force-pushed
the
mitchell/dx-2977
branch
from
3ba404c to
9281598
Compare
Naatan
requested changes
Jul 29, 2024
internal/runners/packages/import.go
Outdated
Comment on lines
157
to
161
| if strings.Contains(verr, "non-existent namespace: private/") { | ||
| if err := localcommit.Set(proj.Dir(), stagedCommitId.String()); err != nil { | ||
| return locale.WrapError(err, "err_package_update_commit_id") | ||
| } | ||
| return errImportSbomSolve |
There was a problem hiding this comment.
This is too specific. We should not have awareness of sboms on the state tool side, and definitely should not be string matching errors from the API to localize them here.
I think we should just make this the mechanic for import; we always update the commit regardless of whether the builder errored out. And we forward the API error, which should already be helpful enough on its own.
Naatan
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect the solve to fail, but we should still update the commit so the user can see what was added, even if the runtime is no longer viable.
Note: these tests were passing prior to the runtime refactor landing and the removal of
constants.DisableRuntimein favor of the async runtime config option. The local commit was still being updated despite the runtime failing to solve. Now this is no longer the case, so this PR is trying to work around that.