state update should clean up after itself.
#2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the base branch from
master
to
version/0-43-0-RC1
mitchell-as
force-pushed
the
mitchell/dx-767
branch
from
daf0456 to
5eaa8fc
Compare
mitchell-as
force-pushed
the
mitchell/dx-767
branch
from
5eaa8fc to
ead9512
Compare
MDrakos
requested changes
Dec 19, 2023
internal/updater/updater.go
Outdated
Comment on lines
244
to
245
| multilog.Error("Update directory structure has changed without updating it here, too. "+ | ||
| "installerPath: %s\nupdateDir: %s\nExpected a 'state-update' prefix for the latter", installerPath, updateDir) |
There was a problem hiding this comment.
I can see us changing the structure of updates and getting a bunch of these errors on Rollbar from older versions. I think the error above is enough to report.
MDrakos
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need an explicit integration test check for lack of an update directory because any inability to recognize or delete it will log an error, and our integration tests report log errors as overall failures.