Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate over processes asynchronously. #2962

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Iterate over processes asynchronously. #2962

merged 1 commit into from
Dec 20, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Dec 19, 2023 •
edited by github-actions bot
Loading

BugDX-2373 State Tool hanging on various commands on MacOS

Iterating over processes synchronously on macOS is particularly quite slow.

@mitchell-as
Iterate over processes asynchronously.
d60eba9 
Iterating over processes synchronously on macOS is particularly quite slow.
@github-actions github-actions bot changed the base branch from master to version/0-43-0-RC1 December 19, 2023 21:30
@mitchell-as
Copy link
Contributor Author

Test failure is not due to this PR. It is a usual timeout.

@mitchell-as mitchell-as requested a review from MDrakos December 19, 2023 21:50
@mitchell-as mitchell-as marked this pull request as ready for review December 19, 2023 21:50
MDrakos
MDrakos approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@mitchell-as mitchell-as reopened this Dec 20, 2023
@mitchell-as mitchell-as merged commit 08f1013 into version/0-43-0-RC1 Dec 20, 2023
15 of 20 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2373 branch December 20, 2023 15:22
as-builds added a commit that referenced this pull request Dec 20, 2023
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2962
bf556cd
mitchell-as added a commit that referenced this pull request Feb 6, 2024
@mitchell-as
Revert "Merge pull request #2962 from ActiveState/mitchell/dx-2373"
a4235d2 
This reverts commit 08f1013, reversing
changes made to fc6d0d1.
mitchell-as added a commit that referenced this pull request Feb 6, 2024
@mitchell-as
Revert "Merge pull request #2962 from ActiveState/mitchell/dx-2373"
562b676 
This reverts commit 08f1013, reversing
changes made to fc6d0d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos