state publish
#2951
Merged
state publish
#2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came from DX-1754.
|
Test failures are not due to this PR. |
It's needed for identifying languages to install. Without it, we'd get a "Unsupported platform: Windows -1 10.0.17134.1" error. Also fix some nil pointer exceptions.
mitchell-as
added
Test: package
Test: languages
Test: platforms
and removed
Test: package
Test: languages
Test: platforms
labels
|
@MDrakos please re-review. I found another set of integration test failures that are fixed with: 021913e Note that the whole method is getting messy and is slated for refactor in https://activestatef.atlassian.net/browse/DX-1897. |
MDrakos
previously approved these changes
Dec 15, 2023
There was a problem hiding this comment.
I'm good to merge but I did add a comment that is worth considering.
Comment is here btw: 021913e#r135121863
I guess because it's on a commit it doesn't show up here?
|
Okay, I've added comments: ca2dc45 |
mitchell-as
force-pushed
the
mitchell/dx-2334-3
branch
from
6d5aa3a to
ca2dc45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try again.
This was the problem: 049d1aa. I'm honestly not sure why the tests were passing before vs. after this change. Perhaps something on the platform side changed with regards to typing.
strfmt.DateTimeappears to be equivalent totime.Timefrom Go's perspective, but perhaps serialization changes in some way. Anyway, I'm seeing some recent, unrelated test failures that are due to platform changes, indicating some flux that could be causing trouble here. I'll file tickets to investigate those.