Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge exeutils package into osutils. #2934

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Merge exeutils package into osutils. #2934

merged 1 commit into from
Dec 7, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Dec 7, 2023 •
edited by github-actions bot
Loading

TaskDX-962 Merge `osutils` and `exeutils` packages.

There was overlap in exe extension per OS.

@mitchell-as
Merge exeutils package into osutils.
897b261 
There was overlap in exe extension per OS.
@mitchell-as
Copy link
Contributor Author

Test failures are not due to this PR.

@mitchell-as mitchell-as requested a review from MDrakos December 7, 2023 17:30
@mitchell-as mitchell-as marked this pull request as ready for review December 7, 2023 17:30
MDrakos
MDrakos approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchell-as mitchell-as closed this Dec 7, 2023
@mitchell-as mitchell-as reopened this Dec 7, 2023
@mitchell-as mitchell-as merged commit 2159e6c into version/0-43-0-RC1 Dec 7, 2023
14 of 20 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-962 branch December 7, 2023 18:54
as-builds added a commit that referenced this pull request Dec 7, 2023
@as-builds
Merge branch version/0-43-0-RC1 to adopt changes from PR #2934
6581e9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos