Clean up GitHub Actions. #2921
Merged
Clean up GitHub Actions. #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update verify.yml
mitchell-as
force-pushed
the
mitchell/dx-2339
branch
from
276d0ea to
0a82e57
Compare
mitchell-as
commented
Dec 5, 2023
| language: bash | ||
| if: ne .Shell "cmd" | ||
| value: | | ||
| if ! type "gozip" &> /dev/null; then |
There was a problem hiding this comment.
This was originally needed for the offline-installer, but that was moved to its own repo, so this is no longer needed.
MDrakos
requested changes
Dec 7, 2023
| env: | ||
| ACTIVESTATE_CI: true |
There was a problem hiding this comment.
It makes sense to remove this one here but I think we should include it on workflows that use the state tool as consumers of our analytics could be using this now or may want to in the future.
There was a problem hiding this comment.
I agree. I don't see a usage of state tool without the ACTIVESTATE_CI environment variable defined. Would you please point it out?
There was a problem hiding this comment.
Just searched and it looks like it's all there. Sorry, when I saw it removed I didn't look in the other files.
MDrakos
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task turned into a general GitHub Actions cleanup. It really needed to be done.