Use zsh as shell for macOS integration tests. #2883
Conversation
mitchell-as
commented
Nov 13, 2023
•
mitchell-as
commented
 DX-2142 Our macOS integration tests use zsh, not bash
|
mitchell-as
force-pushed
the
mitchell/dx-2142
branch
7 times, most recently
from
5f0c75b to
177dada
Compare
mitchell-as
changed the title
mitchell-as
force-pushed
the
mitchell/dx-2142
branch
2 times, most recently
from
9233f42 to
7319fe3
Compare
mitchell-as
force-pushed
the
mitchell/dx-2142
branch
from
7319fe3 to
28f0ab8
Compare
|
Previous "Test: all" was successful except for one installer test that has since been fixed. I just didn't want to wait another 40 minutes to confirm it passed. |
| @@ -212,7 +208,7 @@ func (suite *InstallerIntegrationTestSuite) TestInstallerOverwriteServiceApp() { | |||
| ) | |||
| cp.Expect("Done") | |||
| cp.SendLine("exit") | |||
| cp.ExpectExitCode(0) | |||
| cp.ExpectExit() // the return code can vary depending on shell (e.g. zsh vs. bash); just assert the installer shell exited | |||
There was a problem hiding this comment.
Will this type of check be necessary in other integration tests now?
It may be worth considering a new function that wraps ExpectExitCode() and ExpectExit() and uses either one depending on the current shell, but I will leave that up to your discretion.
There was a problem hiding this comment.
It could rear its head in other installer tests, but in all of our other subshell tests that use "exit" followed by "ExpectExitCode(0)", the tests pass. Nathan found a similar issue with shells on Windows: 3d87ecb. It's something we'll have to live with I guess.
