Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit file to .gitignore when migrating to the new project format. #2821

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add commit file to .gitignore when migrating to the new project format. #2821

merged 1 commit into from
Oct 16, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 16, 2023 •
edited by github-actions bot
Loading

TaskDX-2279 As a user my project is updated and .gitignore populated when I use a project with a local order state tool

mitchell-as
mitchell-as commented Oct 16, 2023
View reviewed changes
pkg/projectfile/projectfile.go
if fileutils.DirExists(filepath.Join(projectDir, ".git")) {
err := localcommit.AddToGitIgnore(projectDir)
if err != nil {
multilog.Error("Unable to add local commit file to .gitignore: %v", err)
Copy link
Contributor Author

@mitchell-as mitchell-as Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, project parsing has no outputer for notices, so we cannot notify the user to manually add this file like we do with checkout and init. I've updated the ACs of DX-2263 to support this since that'll be a larger refactor involving prompts at the very least. Outputers should be easier to add there.

@mitchell-as mitchell-as requested a review from MDrakos October 16, 2023 20:27
@mitchell-as mitchell-as marked this pull request as ready for review October 16, 2023 20:27
@mitchell-as mitchell-as merged commit 923f5b4 into version/0-42-0-RC1 Oct 16, 2023
@mitchell-as mitchell-as deleted the mitchell/dx-2279 branch October 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos