Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing integration test #2816

Merged
merged 19 commits into from
Oct 18, 2023
Merged

Fix failing integration test #2816

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d015734
Fix failing integration test
MDrakos Oct 13, 2023
948b421
Add back workaround
MDrakos Oct 13, 2023
1a61bd4
Update test/integration/install_scripts_int_test.go
MDrakos Oct 13, 2023
cb1e136
Move SetEnv call
MDrakos Oct 13, 2023
3d83b4b
Attempt to remove state tool path entry
MDrakos Oct 13, 2023
653f503
Use state rather than full path
MDrakos Oct 13, 2023
28366ce
Remove bin path from env var
MDrakos Oct 13, 2023
09e281e
Set path in test
MDrakos Oct 13, 2023
8896ec2
Attempt setting home dir in tests
MDrakos Oct 13, 2023
0f5f1db
Debug bashrc file
MDrakos Oct 13, 2023
c0f56ad
Attempt to clean user env
MDrakos Oct 13, 2023
37990d9
Clean up
MDrakos Oct 13, 2023
a82db54
Revert changes when test ends
MDrakos Oct 16, 2023
acffb1d
Add comments
MDrakos Oct 17, 2023
a40de3f
Update version.txt
Oct 17, 2023
9b39505
Merge branch version/0-42-0-RC1 to adopt changes from PR #2825
as-builds Oct 17, 2023
f34e72a
Merge branch version/0-42-0-RC1 to adopt changes from PR #2823
as-builds Oct 17, 2023
547de6e
Merge branch 'version/0-43-0-RC1' into DX-2246
MDrakos Oct 18, 2023
0ce5a84
Fix formatting
MDrakos Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/integration/install_scripts_int_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,10 @@ func (suite *InstallScriptsIntegrationTestSuite) TestInstall() {
suite.NoError(err)
suite.FileExists(stateExec)


suite.assertBinDirContents(binPath)
suite.assertCorrectVersion(ts, binPath, tt.Version, tt.Channel)
suite.assertAnalytics(ts)
MDrakos marked this conversation as resolved.
Show resolved Hide resolved
suite.DirExists(ts.Dirs.Config)

// Verify that can install overtop
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.42.0-RC1
0.43.0-RC1