Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer should check for an xml file by comparing the first few bytes instead of depending on file. #2785

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Installer should check for an xml file by comparing the first few bytes instead of depending on file. #2785

merged 1 commit into from
Oct 3, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 3, 2023 •
edited by github-actions bot
Loading

StoryDX-2212 We should not depend on the `file` utility to install the State Tool

@mitchell-as
Copy link
Contributor Author

Test failures are due to timeouts in runtime setup, not the install.sh command.

@mitchell-as mitchell-as requested a review from Naatan October 3, 2023 20:07
@mitchell-as mitchell-as marked this pull request as ready for review October 3, 2023 20:07
@mitchell-as mitchell-as closed this Oct 3, 2023
@mitchell-as mitchell-as reopened this Oct 3, 2023
@mitchell-as mitchell-as merged commit 8dceb28 into version/0-42-0-RC1 Oct 3, 2023
12 of 19 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2212 branch October 3, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naatan Naatan Naatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @Naatan