Code

Update to termtest v2#2731

Code

Merged

Naatan merged 146 commits intoversion/0-42-0-RC1ActiveState/cli:version/0-42-0-RC1from DX-1910ActiveState/cli:DX-1910Copy head branch name to clipboardSep 25, 2023

+9,862-8,389

Commits

Commits on Jun 28, 2023

• Replacing termtest v1 with v2

  Naatan

  committed
  1307185

  Copy full SHA for 1307185

Commits on Jul 5, 2023

• WIP: Move tests to termtest v2

  Naatan

  committed
  be9a8be

  Copy full SHA for be9a8be

Commits on Aug 23, 2023

• Update termtest package to get terminal emulation fix

  Naatan

  committed
  de70855

  Copy full SHA for de70855

• Add missing import

  Naatan

  committed
  267cc04

  Copy full SHA for 267cc04

• Merge branch 'version/0-41-0-RC1' into DX-1910

  Show description for 0d145bd
  Naatan

  committed
  0d145bd

  Copy full SHA for 0d145bd

• @Naatan

  Show description for b035e17
  Naatan

  committed
  b035e17

  Copy full SHA for b035e17

• Fix activate test

  Naatan

  committed
  7a4740d

  Copy full SHA for 7a4740d

• Use Output() instead of Snapshot() as that was what the original implementation did, despite the name

  Naatan

  committed
  22b87e8

  Copy full SHA for 22b87e8

• Update modules

  Naatan

  committed
  62a713e

  Copy full SHA for 62a713e

• Fix tests using Send() where they should be using SendLine()

  Naatan

  committed
  ef1f227

  Copy full SHA for ef1f227

• Update termtest to get race condition fix with Send()

  Naatan

  committed
  e4f10ad

  Copy full SHA for e4f10ad

Commits on Aug 24, 2023

• Update termtest

  Naatan

  committed
  68a4734

  Copy full SHA for 68a4734

• Don't continue running test when they can't possibly succeed

  Naatan

  committed
  4d54662

  Copy full SHA for 4d54662

• Fix ExpectInput not matching the right thing

  Naatan

  committed
  22d365c

  Copy full SHA for 22d365c

• Don't rely on SHELL

  Naatan

  committed
  bef1afc

  Copy full SHA for bef1afc

• Fix SpawnShell failing if there are no further args

  Naatan

  committed
  b67f686

  Copy full SHA for b67f686

• Don't run shells within shells

  Naatan

  committed
  d2b2e30

  Copy full SHA for d2b2e30

Commits on Aug 25, 2023

• Update termtest

  Naatan

  committed
  c4fc3ed

  Copy full SHA for c4fc3ed

• Leave default to run inside shell for now

  Naatan

  committed
  29caa61

  Copy full SHA for 29caa61

Commits on Aug 28, 2023

• Update termtest

  Naatan

  committed
  dbc69da

  Copy full SHA for dbc69da

• Ensure errors are surfaced

  Naatan

  committed
  ff93152

  Copy full SHA for ff93152

• Update termtest to get windows fixes

  Naatan

  committed
  1f57ac0

  Copy full SHA for 1f57ac0

• Update termtest

  Naatan

  committed
  db8a297

  Copy full SHA for db8a297

• Fix interrupt test

  Naatan

  committed
  728c3ad

  Copy full SHA for 728c3ad

• Work around line ending issue

  Naatan

  committed
  0129cb0

  Copy full SHA for 0129cb0

• Fix test depending on terminal col width

  Naatan

  committed
  3d8ed79

  Copy full SHA for 3d8ed79

Commits on Aug 29, 2023

• Fix unable to run subtest

  Naatan

  committed
  512973b

  Copy full SHA for 512973b

• Turn on verbose logging to debug

  Naatan

  committed
  0958d3e

  Copy full SHA for 0958d3e

• Limit terminal colums to 140 so we can check Snapshot() output without tons of whitespace

  Naatan

  committed
  62aed26

  Copy full SHA for 62aed26

• Work around SendLine race condition

  Naatan

  committed
  1d89d41

  Copy full SHA for 1d89d41

• Fix test sending too many enter keys

  Naatan

  committed
  2da75d7

  Copy full SHA for 2da75d7

• Use SendEnter()

  Naatan

  committed
  2114af3

  Copy full SHA for 2114af3

• Fix spawning commands not working on Windows

  Naatan

  committed
  d150396

  Copy full SHA for d150396

• Drop verbose flag on tests

  Naatan

  committed
  cf5dc7e

  Copy full SHA for cf5dc7e

• Fix test not matching cause of wrapping

  Naatan

  committed
  46d18b1

  Copy full SHA for 46d18b1

• Create org as part of new user creation in tests

  Naatan

  committed
  b2e9bf2

  Copy full SHA for b2e9bf2

• Fix test relying on VERBOSE=true

  Naatan

  committed
  a7b453e

  Copy full SHA for a7b453e

• Don't run tests inside shell

  Naatan

  committed
  04fd9ae

  Copy full SHA for 04fd9ae

• Fix test using wrong method to retrieve executable

  Naatan

  committed
  617e4c5

  Copy full SHA for 617e4c5

• Give activation tests plenty of time

  Naatan

  committed
  6d831bd

  Copy full SHA for 6d831bd

• Let implementer decide whether SendInput is appropriate

  Naatan

  committed
  269ad07

  Copy full SHA for 269ad07

Commits on Aug 30, 2023

• Match casing of prompt

  Naatan

  committed
  27e6612

  Copy full SHA for 27e6612

• Debug test

  Naatan

  committed
  8fddb49

  Copy full SHA for 8fddb49

• Always use cmd style expect assertions on Windows, except when using bash

  Naatan

  committed
  20b4bde

  Copy full SHA for 20b4bde

• Attempt to fix race condition

  Naatan

  committed
  b6aa8ec

  Copy full SHA for b6aa8ec

• Set verbosity on the right level

  Naatan

  committed
  fe51e22

  Copy full SHA for fe51e22

• Wait until process exits to assert

  Naatan

  committed
  7352999

  Copy full SHA for 7352999

• Ensure activate has sufficient time

  Naatan

  committed
  ae4652c

  Copy full SHA for ae4652c

• Fix test assertion being too specific

  Naatan

  committed
  315370f

  Copy full SHA for 315370f

• Always strip windows line endings

  Naatan

  committed
  f69c370

  Copy full SHA for f69c370

• Normalize line endings across the board

  Naatan

  committed
  45d1564

  Copy full SHA for 45d1564

• Also run baseline in verbose

  Naatan

  committed
  cb6036a

  Copy full SHA for cb6036a

• Work around pty bug on windows

  Naatan

  committed
  aac5d49

  Copy full SHA for aac5d49

Commits on Aug 31, 2023

• Only report termtest logs for failed test

  Naatan

  committed
  c4c6397

  Copy full SHA for c4c6397

• Give checkout enough time

  Naatan

  committed
  fce6b32

  Copy full SHA for fce6b32

• Give windows extra time before sending input

  Naatan

  committed
  92cc3be

  Copy full SHA for 92cc3be

• Update termtest to address potential premature close issue

  Naatan

  committed
  e2bdc7a

  Copy full SHA for e2bdc7a

• Revert "Create org as part of new user creation in tests"

  Show description for f414c88
  Naatan

  committed
  f414c88

  Copy full SHA for f414c88

• Fix logs not populated

  Naatan

  committed
  35596a7

  Copy full SHA for 35596a7

• Revert windows output workaround as it creates false positives

  Naatan

  committed
  a260bf3

  Copy full SHA for a260bf3

• Attempt to work around pty output issues on windows

  Naatan

  committed
  8028459

  Copy full SHA for 8028459

• Fix bad formatting

  Naatan

  committed
  e61e47a

  Copy full SHA for e61e47a

• Attempt to fix missing termtest log

  Naatan

  committed
  75af502

  Copy full SHA for 75af502

Commits on Sep 1, 2023

• Update termtest

  Naatan

  committed
  c9c22c8

  Copy full SHA for c9c22c8

Commits on Sep 5, 2023

• Fix sleep being way too long

  Naatan

  committed
  aea2f04

  Copy full SHA for aea2f04

• Drop custom timeouts where not needed

  Naatan

  committed
  6a22271

  Copy full SHA for 6a22271

• Update termtest

  Naatan

  committed
  7e3e851

  Copy full SHA for 7e3e851

• Disable executor verbosity as it's making it difficult to read test results

  Naatan

  committed
  3ccd4d4

  Copy full SHA for 3ccd4d4

• Increase test time

  Naatan

  committed
  150a575

  Copy full SHA for 150a575

• cmd doesn't like single quotes

  Naatan

  committed
  2926b38

  Copy full SHA for 2926b38

• Fix test

  Naatan

  committed
  66bb9ec

  Copy full SHA for 66bb9ec

Commits on Sep 6, 2023

• Try to fix failing test

  Naatan

  committed
  d7d04d2

  Copy full SHA for d7d04d2

• Give runtime sourcing enough time

  Naatan

  committed
  4679e3a

  Copy full SHA for 4679e3a

• Give enough time

  Naatan

  committed
  3f32568

  Copy full SHA for 3f32568

• Simplify test

  Naatan

  committed
  96e7caa

  Copy full SHA for 96e7caa

• Fix nil pointer when runtime sourcing is disabled

  Naatan

  committed
  812a768

  Copy full SHA for 812a768

• Give more time for runtime sourcing

  Naatan

  committed
  f672c7d

  Copy full SHA for f672c7d

• Make it easier to debug test failures

  Naatan

  committed
  8599937

  Copy full SHA for 8599937

• Accessing env information requires non-disabled runtime

  Naatan

  committed
  3c9b9b3

  Copy full SHA for 3c9b9b3

Commits on Sep 8, 2023

• Update termtest

  Naatan

  committed
  8166f66

  Copy full SHA for 8166f66

• Fix test name

  Naatan

  committed
  7edd21d

  Copy full SHA for 7edd21d

• Update termtest

  Naatan

  committed
  763d698

  Copy full SHA for 763d698

• Update termtest

  Naatan

  committed
  4c9b83d

  Copy full SHA for 4c9b83d

Commits on Sep 11, 2023

• Debug

  Naatan

  committed
  26afb93

  Copy full SHA for 26afb93

• Disable defender on Windows

  Naatan

  committed
  3fc8bdc

  Copy full SHA for 3fc8bdc

• Disable logging service requests

  Naatan

  committed
  9991305

  Copy full SHA for 9991305

• Fix CI step

  Naatan

  committed
  55f0185

  Copy full SHA for 55f0185

• Fix step on WIndows

  Naatan

  committed
  2c77b2f

  Copy full SHA for 2c77b2f

• Update termtest

  Naatan

  committed
  061fe7b

  Copy full SHA for 061fe7b

Commits on Sep 12, 2023

• Remove verbose logging

  Naatan

  committed
  cc86c70

  Copy full SHA for cc86c70

• Fix vscode test

  Naatan

  committed
  49bc64e

  Copy full SHA for 49bc64e

• Debug

  Naatan

  committed
  4087dc2

  Copy full SHA for 4087dc2

• Revert "Debug"

  Show description for e1fc84b
  Naatan

  committed
  e1fc84b

  Copy full SHA for e1fc84b

• Update termtest

  Naatan

  committed
  88c2df1

  Copy full SHA for 88c2df1

• Update termtest

  Naatan

  committed
  6208b05

  Copy full SHA for 6208b05

Commits on Sep 13, 2023

• Reduce chance of race condition

  Naatan

  committed
  7d126eb

  Copy full SHA for 7d126eb

• Update termtest

  Naatan

  committed
  153c5f4

  Copy full SHA for 153c5f4

• Give runtime sourcing enough time

  Naatan

  committed
  9073b64

  Copy full SHA for 9073b64

• Give runtime sourcing time

  Naatan

  committed
  20d7882

  Copy full SHA for 20d7882

• Debug test

  Naatan

  committed
  fc0fd35

  Copy full SHA for fc0fd35

• Debug log escape sequences

  Naatan

  committed
  6d7da13

  Copy full SHA for 6d7da13

• Update termtest

  Naatan

  committed
  0e1cb41

  Copy full SHA for 0e1cb41

• Fix SendLine called too early

  Naatan

  committed
  8a67c52

  Copy full SHA for 8a67c52

Commits on Sep 14, 2023

• Use snapshot because output is error prone due to cleaning

  Naatan

  committed
  5c1cee5

  Copy full SHA for 5c1cee5

• Fix assertion

  Naatan

  committed
  8b1e725

  Copy full SHA for 8b1e725

• Fix assertion with branch listing

  Naatan

  committed
  939e670

  Copy full SHA for 939e670

• Update termtest

  Naatan

  committed
  5b4b674

  Copy full SHA for 5b4b674

• Disable verbose logging

  Naatan

  committed
  d8479b3

  Copy full SHA for d8479b3

• Attempt to fix failed assertion due to line break

  Naatan

  committed
  028a14d

  Copy full SHA for 028a14d

• Update termtest

  Naatan

  committed
  d592514

  Copy full SHA for d592514

• Also delay on regular sends on Windows

  Naatan

  committed
  456c9dd

  Copy full SHA for 456c9dd

• Work around posix escape sequences on Windows

  Naatan

  committed
  fe4ed94

  Copy full SHA for fe4ed94

• Use snapshot output for quick debugging as it gives a better sense of what happened

  Naatan

  committed
  28bfd81

  Copy full SHA for 28bfd81

• Drop useless comments

  Naatan

  committed
  9fb3d7e

  Copy full SHA for 9fb3d7e

• Skip tests on Windows for now as SendKeyDown doesn't work

  Naatan

  committed
  ce521cc

  Copy full SHA for ce521cc

• Wait for exit first

  Naatan

  committed
  8f42ce9

  Copy full SHA for 8f42ce9

• Prevent assertion issues due to escape sequences (color codes)

  Naatan

  committed
  5b2395c

  Copy full SHA for 5b2395c

• Account for color codes in assertion

  Naatan

  committed
  6c6b63b

  Copy full SHA for 6c6b63b

Commits on Sep 15, 2023

• Reduce chance of race

  Naatan

  committed
  be95799

  Copy full SHA for be95799

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Naatan

  committed
  2f61728

  Copy full SHA for 2f61728

• Convert tests to termtest v2

  Naatan

  committed
  2110f00

  Copy full SHA for 2110f00

Commits on Sep 18, 2023

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Naatan

  committed
  6759c04

  Copy full SHA for 6759c04

• Give runtime sourcing more time

  Naatan

  committed
  9c77bd6

  Copy full SHA for 9c77bd6

• Enable code that was disabled for v1 of termtest

  Naatan

  committed
  7d7e365

  Copy full SHA for 7d7e365

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Show description for 4f62fad
  Naatan

  committed
  4f62fad

  Copy full SHA for 4f62fad

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Show description for 47fae4d
  Naatan

  committed
  47fae4d

  Copy full SHA for 47fae4d

Commits on Sep 19, 2023

• Merge branch 'version/0-41-0-RC1' into DX-1910

  Naatan

  committed
  7177cf1

  Copy full SHA for 7177cf1

• Update tests to use new API

  Naatan

  committed
  69e8445

  Copy full SHA for 69e8445

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Show description for f40a517
  Naatan

  committed
  f40a517

  Copy full SHA for f40a517

• Update tests to termtest v2 api

  Naatan

  committed
  4da3f5b

  Copy full SHA for 4da3f5b

• Fix test

  Naatan

  committed
  f5f92c0

  Copy full SHA for f5f92c0

• Fix test

  Naatan

  committed
  fb4684e

  Copy full SHA for fb4684e

Commits on Sep 20, 2023

• Give windows more time to delete files

  Naatan

  committed
  205678b

  Copy full SHA for 205678b

• Merge branch 'version/0-42-0-RC1' into DX-1910

  Show description for 5ec5c03
  Naatan

  committed
  5ec5c03

  Copy full SHA for 5ec5c03

Commits on Sep 25, 2023

• Fix typo

  Naatan

  committed
  65cd5d8

  Copy full SHA for 65cd5d8

• Fix incorrect name in comment

  Naatan

  committed
  03a4736

  Copy full SHA for 03a4736

• Make comment more specific

  Naatan

  committed
  a1bf3d0

  Copy full SHA for a1bf3d0

• Add link to jira ticket

  Naatan

  committed
  b93bacc

  Copy full SHA for b93bacc

• Add comments explaining flags

  Naatan

  committed
  dd8cb15

  Copy full SHA for dd8cb15

• Use variable instead of hard coded string

  Naatan

  committed
  5ed621c

  Copy full SHA for 5ed621c

• Add comment

  Naatan

  committed
  89d6a7a

  Copy full SHA for 89d6a7a

• Add comment with rationale to ExpectRE

  Naatan

  committed
  5331492

  Copy full SHA for 5331492

• Merge remote-tracking branch 'origin/version/0-42-0-RC1' into DX-1910

  Naatan

  committed
  c1debf8

  Copy full SHA for c1debf8

• Update new tests to use termtest v2 api

  Naatan

  committed
  68fa6b9

  Copy full SHA for 68fa6b9

• Use cmd var

  Naatan

  committed
  fea0746

  Copy full SHA for fea0746

• Add comment with rationale about exit code

  Naatan

  committed
  3d87ecb

  Copy full SHA for 3d87ecb