Quote state exec arguments on Windows.

ActiveState · Mar 22, 2024 · 364b0c4 · 364b0c4
1 parent d47d8ff
commit 364b0c4
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 4 deletions.
diff --git a/internal/osutils/shellescape.go b/internal/osutils/shellescape.go
@@ -12,7 +12,7 @@ type ShellEscape struct {
 	escapeWith    string
 }
 
-//NewBashEscaper creates a new instance of ShellEscape that's configured for escaping bash style arguments
+// NewBashEscaper creates a new instance of ShellEscape that's configured for escaping bash style arguments
 func NewBashEscaper() *ShellEscape {
 	return &ShellEscape{
 		regexp.MustCompile(`^[\w]+$`),
@@ -33,7 +33,7 @@ func NewBatchEscaper() *ShellEscape {
 // NewCmdEscaper creates a new instance of ShellEscape that's configured for escaping cmd arguments
 func NewCmdEscaper() *ShellEscape {
 	return &ShellEscape{
-		regexp.MustCompile(`^[^ &()\[\]{}^=;!'+,~]+$`), // cmd.exe /? lists these characters as requiring quotes
+		regexp.MustCompile(`^[^ &()\[\]{}^=;!'+,~<>]+$`), // cmd.exe /? lists these characters as requiring quotes
 		regexp.MustCompile(`"`),
 		`""`,
 	}

diff --git a/internal/runners/exec/exec.go b/internal/runners/exec/exec.go
@@ -197,7 +197,7 @@ func (s *Exec) Run(params *Params, args ...string) (rerr error) {
 	scriptArgs := fmt.Sprintf(`%q "$@"`, exeTarget)
 	if strings.Contains(s.subshell.Binary(), "cmd") {
 		lang = language.Batch
-		scriptArgs = fmt.Sprintf("@ECHO OFF\n%q %%*", exeTarget)
+		scriptArgs = fmt.Sprintf(`@ECHO OFF\n%q %%*`, exeTarget)
 	}
 
 	sf, err := scriptfile.New(lang, "state-exec", scriptArgs)

diff --git a/internal/subshell/sscommon/sscommon.go b/internal/subshell/sscommon/sscommon.go
@@ -137,7 +137,12 @@ func runWithCmd(env []string, name string, args ...string) error {
 		return locale.NewInputError("err_sscommon_unsupported_language", "", ext)
 	}
 
-	return runDirect(env, name, args...)
+	esc := osutils.NewCmdEscaper()
+	quoted := make([]string, 0, len(args))
+	for _, arg := range args {
+		quoted = append(quoted, esc.Quote(arg))
+	}
+	return runDirect(env, name, quoted...)
 }
 
 func binaryPathCmd(env []string, name string) (string, error) {

diff --git a/test/integration/exec_int_test.go b/test/integration/exec_int_test.go
@@ -197,6 +197,26 @@ func (suite *ExecIntegrationTestSuite) TestExecWithPath() {
 
 }
 
+func (suite *ExecIntegrationTestSuite) TestExecQuotedArgs() {
+	suite.OnlyRunForTags(tagsuite.Exec)
+	ts := e2e.New(suite.T(), false)
+	defer ts.Close()
+
+	cp := ts.Spawn("checkout", "ActiveState-CLI/Perl-5.32", ".")
+	cp.Expect("Skipping runtime setup")
+	cp.Expect("Checked out project")
+	cp.ExpectExitCode(0)
+
+	fileutils.WriteFile(filepath.Join(ts.Dirs.Work, "testargs.txt"), []byte(`printf "Argument: '%s'.\n", $ARGV[0];`))
+
+	cp = ts.SpawnWithOpts(
+		e2e.OptArgs("exec", "perl", "testargs.txt", "a<b"),
+		e2e.OptAppendEnv(constants.DisableRuntime+"=false"),
+	)
+	cp.Expect("Argument: 'a<b'.", e2e.RuntimeSourcingTimeoutOpt)
+	cp.ExpectExitCode(0)
+}
+
 func TestExecIntegrationTestSuite(t *testing.T) {
 	suite.Run(t, new(ExecIntegrationTestSuite))
 }