Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAIZ-7241: Add pnpm support. #7

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG ROCKY_VERSION
FROM rockylinux:${ROCKY_VERSION}-minimal
FROM rockylinux:${ROCKY_VERSION}-minimal AS base

ARG NODE_VERSION

Expand Down Expand Up @@ -40,3 +40,7 @@
microdnf --nodocs install -y tzdata && \
microdnf clean all && \
rm -rf /var/cache/*

FROM base AS pnpm

RUN npm install -g pnpm

Check failure on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / main

DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`
11 changes: 8 additions & 3 deletions docker-bake.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,23 @@ group "default" {
}

target "nodejs" {
name = "nodejs-${node_version}"
name = "nodejs-${tgt}-${node_version}"
matrix = {
node_version = [
"18",
"20",
]
tgt = [
"base",
"pnpm"
]
}

target = tgt
pull = true
tags = [
"acornsaustralia/node:${node_version}",
GITHUB_RUN_NUMBER != null ? "acornsaustralia/node:${node_version}-${GITHUB_RUN_NUMBER}" : ""
"acornsaustralia/node:${tgt}-${node_version}",
GITHUB_RUN_NUMBER != null ? "acornsaustralia/node:${node_version}-${tgt}-${GITHUB_RUN_NUMBER}" : ""
]
platforms = [
"linux/amd64"
Expand Down