Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscale issue #6: despite the batch count of Upscale operations fixed at 1, multiple upscales are still enabled; the Upscale button has to be disabled #1270

Closed
valery016 opened this issue Oct 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@valery016
Copy link

valery016 commented Oct 16, 2024

It does make sense to fix the batch count of the Upscale operation at 1, as it’s done currently, but why then is the Upscale button not grayed out after the user has clicked on it? As it is now, it is possible for the user to click multiple times on the Upscale button while the operation is still in progress, which effectively - sort of - enables the batch count to be bigger than one. This leads to a progressive upscaling which, to me, makes little sense, and is rather hazardous: I see that Krita is happy to upscale a 1024x1024 image into a 8Kx8K one in a flash upon 3 clicks on the Upscale, while the plugin is lagging much behind. When it’s done at last, what we see is a stack of layers of various sizes beneath the top largest one and atop of the Krita-enlarged 8Kx8K background. This is hardly of any use.

When the Scale is set to 1,00x and Refine is not checked, this button is not blocked either when the operation has begun, so the user is free to click on it as many times as they like. Which leads to creating duplicates of the same layer, while the processing time is still being used, for some mysterious reason.
Only when the Refine is checked does allowing multiple subsequent clicks on Upscale make some sense, but I doubt anyone will want this without checking what is happening at each stage. As it is now, the plugin will perform a refine operation, place the resulting layer automatically atop of the source one, immediately use it for another refinement, and so on. The product of this, when for instance Refine is clicked on 3 times with a 40% Strength, is likely a visual horror.

@valery016 valery016 changed the title Upscale issue #6: despite the batch count of the Upscale operations fixed at 1, subsequent upscales are still enabled; the Upscale button has to be disabled Upscale issue #6: despite the batch count of Upscale operations fixed at 1, multiple upscales are still enabled; the Upscale button has to be disabled Oct 16, 2024
@Acly Acly added the enhancement New feature or request label Oct 18, 2024
@Acly
Copy link
Owner

Acly commented Nov 12, 2024

Button is disabled during upscale in v1.28.0

@Acly Acly closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants