Skip to content

Commit

Permalink
Comments addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
Achintha Isuru committed Oct 22, 2023
1 parent 7ee4e2e commit 31b88ad
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
1 change: 1 addition & 0 deletions .changeset/unlucky-onions-reply.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
"@wso2is/console": patch
"@wso2is/myaccount": patch
"@wso2is/identity-apps-core": patch
"@wso2is/i18n": patch
---
Expand Down
12 changes: 5 additions & 7 deletions apps/console/src/features/roles/components/role-list-updated.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,11 @@ import React, { ReactElement, ReactNode, SyntheticEvent, useState } from "react"
import { useTranslation } from "react-i18next";
import { useSelector } from "react-redux";
import { Header, Icon, Label, SemanticICONS } from "semantic-ui-react";
import {
AppConstants,
AppState,
FeatureConfigInterface,
getEmptyPlaceholderIllustrations,
history
} from "../../core";
import { getEmptyPlaceholderIllustrations } from "../../core/configs/ui";
import { AppConstants } from "../../core/constants/app-constants";
import { history } from "../../core/helpers/history";
import { FeatureConfigInterface } from "../../core/models/config";
import { AppState } from "../../core/store/index";
import { RoleAudiences } from "../models";

interface RoleListProps extends LoadableComponentInterface, IdentifiableComponentInterface {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class RoleConstants {
];

/**
* filter query for audience type application.
* Filter query for audience type application.
*/
public static readonly ROLE_AUDIENCE_APPLICATION_FILTER: string = "audience.type eq application";

Expand Down
5 changes: 3 additions & 2 deletions apps/console/src/features/roles/pages/role-updated.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* specific language governing permissions and limitations
* under the License.
*/

import { AccessControlConstants, Show } from "@wso2is/access-control";
import { AlertInterface, AlertLevels, IdentifiableComponentInterface, RolesInterface } from "@wso2is/core/models";
import { addAlert } from "@wso2is/core/store";
Expand Down Expand Up @@ -93,7 +94,7 @@ const RolesPage: FunctionComponent<RolesPagePropsInterface> = (
*/
useEffect(() => {
if (rolesListError) {
dispatch(addAlert<AlertInterface>({
handleAlerts(addAlert<AlertInterface>({
description: t("console:manage.features.roles.notifications.fetchRoles.genericError.description"),
level: AlertLevels.ERROR,
message: t("console:manage.features.roles.notifications.fetchRoles.genericError.message")
Expand Down Expand Up @@ -204,7 +205,7 @@ const RolesPage: FunctionComponent<RolesPagePropsInterface> = (
value: "displayName"
},
{
key: 0,
key: 1,
text: t("console:manage.features.roles.list.filterAttirbutes.audience"),
value: "audience.type"
}
Expand Down

0 comments on commit 31b88ad

Please sign in to comment.