Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nodes maintain ordering while opening or closing #8

Conversation

catosaurusrex2003
Copy link
Contributor

context: #5 (comment)

BEFORE (notice how the ordering of the node changes every time I click):
https://github.com/user-attachments/assets/ec64b027-b2fe-460d-9015-7e0c917e0c06

AFTER (the ordering doesnt change anymore):
https://github.com/user-attachments/assets/572dc5d3-f7fc-4c11-a612-9b835c68b1bc

Copy link
Owner

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catosaurusrex2003 can i see a short video of this implementation?

@catosaurusrex2003
Copy link
Contributor Author

@AceTheCreator I have attached 2 videos 👀

Do you need something else

Copy link
Owner

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@AceTheCreator AceTheCreator merged commit 165bfd5 into AceTheCreator:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants