Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added switching to specific device #152

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

f1andrew
Copy link
Contributor

@f1andrew f1andrew commented Sep 4, 2023

No description provided.

@willwade
Copy link
Contributor

@f1andrew what do you think about adding something to help with #153 to this PR? Workable?

@joedevsys
Copy link
Contributor

After a few seconds I get the "trying to switch to " notification. then after a few more seconds a command window pops up for a short time: AppInstallerPythonRedirector.exe but no further notification. (Connection succeeds quietly).

@f1andrew
Copy link
Contributor Author

f1andrew commented Sep 20, 2023

Here is isolated test of sending notification from background process.
Main.py should launch background subprocess and return. After that subprocess_file.py after delay should send notification.
Try to run it on communicator and let me know does it work.

subprocess_test.zip

@joedevsys
Copy link
Contributor

Calling "python Mainpy" from Communicator5 (fullscreen): during the delay while subprocess_file.py is running a python cmd window appears on top of Communicator (not good!). Later this gets closed and a notification pops up (good!).

Renamed both files to .pyw. Changed main.pyw to call "subprocess_file.exe" and compiled both using Pyinstaller. This now works correctly. No command window is displayed and a notification appears after a few seconds.

(I did not succeed with the Pyinstaller --onefile switch. This causes main.exe to not find subprocess_file.exe. I probably need to fix paths somewhere. --onefile is ok with subprocess_file.exe but not with main.exe)

@willwade
Copy link
Contributor

willwade commented Sep 21, 2023

I've added this as a draft release to aid anyone's testing https://github.com/AceCentre/RelayKeys/releases/tag/2.01 (@quaxalber - I've recreated all the UF2 files )

NB: I'm finding a problem with this install. Beware! I'm looking into it..

e.g..
Screenshot 2023-09-21 at 15 24 39

@f1andrew
Copy link
Contributor Author

Previously I tested it only with Python.
I've added poll_devname into build and added option of running built exe.
So now built version should be working too.

@willwade
Copy link
Contributor

Fab! I've updated the Pre-release with the full updated installer . Thanks @f1andrew

@quaxalber
Copy link
Contributor

quaxalber commented Sep 27, 2023

I've updated the Pre-release with the full updated installer

The exe from the updated installer yields this error for me @willwade

image

Apologies for the delay on my end. I've been working on my other project, which is a nice addition for my setup. I'm thinking if you might want to integrate it into RK? Since this is probably not the right place for discussion, feel free to email me your thoughts.

@willwade
Copy link
Contributor

willwade commented Sep 27, 2023

Update @f1andrew - I see its looking for _internals/cli_keymaps - but why? Is this a pyinstaller thing?

. Re Bluetooth -> hid did you see our dongle recieving code? It does this but is designed for relaykeys (i,e. not BLE HID receiving - but RelayKey sending). The other way we have done this is on a esp32. They have some nice code that acts as a BLE HID host see https://github.com/AceCentre/open-ble-screen. But I like your pi approach! I know a team desperate for that setup

@quaxalber
Copy link
Contributor

quaxalber commented Sep 28, 2023

did you see our dongle recieving code?

I was aware of this feature, but for some reason I ditched this idea early on, because in my head I thought it wouldn't work on my work notebook, since its endpoint security blocks any Bluetooth interfaces (including Bluetooth adaptor dongles). But the RK receiver would identify itself as HID, just like my solution, right? Do you think it would work to plug the RK receiver into a KVM switch?

I know a team desperate for that setup

Sounds great, glad if this helped others too.

But I like your pi approach!

Thanks @willwade ! :)

@f1andrew
Copy link
Contributor Author

f1andrew commented Oct 4, 2023

@willwade
This is because of pyinstaller update. They released new version 6.0 on sep 23.
It's building somehow different and causes issue with path.
I will look more about it.

For now, it's better to revert to 5.13.2 and build it again. Build made with this version works.
Here is command for reverting pyinstaller version:
pip install --force-reinstall pyinstaller==5.13.2

@willwade
Copy link
Contributor

willwade commented Oct 5, 2023

Thanks @f1andrew - I'm going to merge this - I cant see it breaking anything and it will be easier to test. I have a feeling the pyinstaller on the GH Action pipeline wont be updated so I'll see if the same thing is happening there.

@willwade willwade merged commit 7ef8c25 into AceCentre:master Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants