Running php-cs-fixer fix #28
Conversation
Sam-Burns
force-pushed
the
php-cs-fixer
branch
3 times, most recently
from
164895b
to
6d0a070
Compare
Sam-Burns
force-pushed
the
php-cs-fixer
branch
from
6d0a070
to
701c745
Compare
|
Maybe setup https://styleci.io/? |
|
@GrahamCampbell that's a good idea, I'll look into it. Maybe with Scrutinizer checks already running, we should be able to spot any issues in future PRs though? I'll find out more about what styleci can offer. |
|
StyleCI can offer full automation for CS fixing including sending and merging PRs both at request, or, automatically on push. It's good to separate this from scrutinzier so StyleCI can focus on the cs, travis on the tests, and scrutinizer on the static analysis and code inspection. I find that scrutinizer does a poor job of dealing with cs. NB I'm maybe biased because I'm lead dev for StyleCI. |
|
StyleCI is particularly good when it comes to merging external PRs with cs issues. If you've got auto sending/merging turned on, after you merge a PR, StyleCI can merge the fixes straight after. This means contributors don't need to worry about cs anymore, and people can focus on the code, not the cs. This is very useful in Laravel for example. |
|
@Sam-Burns would you like a hand with this? |
Ran
php-cs-fixer fix src/ --level=psr2andphp-cs-fixer fix tests/ --level=psr2.