-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rwh_05 feature flag #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed test 1
failed test 2
|
This allows using accesskit with current versions of wgpu. Winit has a similar system to widden its support. See rust-windowing/winit#3126
Tests green on windows as of f729859 |
Hello @nicopap, thank you for handling this! I am happy with your work but the PR is still a draft, do you want to add something else? |
Tested on macOS, tests are OK. |
DataTriny
approved these changes
Dec 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using accesskit with current and older versions of wgpu. Typically this is a requirement for game developers, or low level UI toolkit developers.
Changelog
Added the
rwh_05
andrwh_06
feature flags to theaccesskit_winit
crate.This allows consumers of the
accesskit_winit
crate to pick and chose which version ofraw-window-handle
accesskit_winit
will depend on.rwh_05
enables thewinit
rwh_05
feature flag, which uses theraw-window-handle
version0.5
.rwh_06
is similar torwh_05
, but forraw-window-handle
version0.6
.See rust-windowing/winit#3075 for a discussion of why this is wanted.
rwh_06
is enabled by default, followingwinit
's convention. If both features are enabled at the same time, acompile_error!
is emitted.Tests
Tested on
Steps to test: