Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Fail creation of unlocked package when test coverage is below 75% #457

Merged
merged 4 commits into from
Mar 22, 2021

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Mar 22, 2021

  • Fail Create unlocked Package command when the coverage is low
  • Incorrect Metrics placement in deploy

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #457 (32ed789) into develop (c7bd65a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #457   +/-   ##
========================================
  Coverage    80.72%   80.72%           
========================================
  Files           32       32           
  Lines         1110     1110           
  Branches       197      197           
========================================
  Hits           896      896           
  Misses         214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bd65a...32ed789. Read the comment docs.

@aly76 aly76 merged commit f24d321 into develop Mar 22, 2021
@aly76 aly76 deleted the fix/break_if_coverage_is_low branch March 22, 2021 02:29
@azlam-abdulsalam azlam-abdulsalam added this to the Milestone 21 milestone Mar 22, 2021
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants