fix(ValidFieldPassword)/adding data-qa-id and data-qa-props for password strength #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayhan-ab
reviewed
Sep 8, 2022
| @@ -27,6 +27,9 @@ export interface ValidFieldPasswordProps extends Omit<ValidFieldTextProps, "type | |||
| customPattern?: string; | |||
| hasPasswordStrengthMeter?: boolean; | |||
| zxcvbnOption?: OptionsType; | |||
| dataQaPasswordStrength?: string; | |||
There was a problem hiding this comment.
could we make it as one object so that we won't have to add plenty of dataQa props? what i mean is like
type DataQa: string | null
interface StrengthMeterDataQa {
bar:? DataQa
barProps?: DataQa
label?: DataQa
}
interface ValidFieldPasswordProps {
...
strengthMeterDataQa?: StrengthMeterDataQa
}
wdyt?
There was a problem hiding this comment.
i think this is better approach
will implement it
andrinuryawan
force-pushed
the
fix/OS-7456-adding-data-qa-props-for-password-strength
branch
from
a02c405
to
2f18765
Compare
rayhan-ab
reviewed
Sep 8, 2022
| {Object.keys(PASSWORD_STRENGTH_METER).map((strengthLevel, index) => ( | ||
| <div | ||
| key={`bar-${strengthLevel}`} | ||
| className={classNames("bar", { fill: index <= passwordStrengthScore })} | ||
| data-qa-props={passwordStrengthDataQa && `${passwordStrengthDataQa.barProps}-${index}`} |
There was a problem hiding this comment.
passwordStrengthDataQa.barProps && ...?
rayhan-ab
reviewed
Sep 8, 2022
| const { passwordStrengthScore } = this.state; | ||
| const strengtLevelText = this.getStrengthLevelBasedOnScore(passwordStrengthScore); | ||
| return ( | ||
| <> | ||
| {hasPasswordStrengthMeter && passwordStrengthScore !== null && ( | ||
| <div className="password-strength-meter"> | ||
| <div className={classNames("strength-meter-bar", strengtLevelText)}> | ||
| <div className={classNames("strength-meter-bar", strengtLevelText)} data-qa-id={passwordStrengthDataQa && passwordStrengthDataQa.bar}> |
rayhan-ab
reviewed
Sep 8, 2022
| /> | ||
| ))} | ||
| </div> | ||
| <span className={classNames("strength-meter-label")}>{translation("password.strength.label")}</span> | ||
| <span className={classNames("strength-meter-level", strengtLevelText)}> | ||
| <span className={classNames("strength-meter-level", strengtLevelText)} data-qa-id={passwordStrengthDataQa && passwordStrengthDataQa.label}> |
…ord strength #minor
andrinuryawan
force-pushed
the
fix/OS-7456-adding-data-qa-props-for-password-strength
branch
from
2f18765
to
c321444
Compare
rayhan-ab
approved these changes
Sep 8, 2022
andrinuryawan
deleted the
fix/OS-7456-adding-data-qa-props-for-password-strength
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.