Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalPage): add css variable to set top and right position #141

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

abdmmar
Copy link
Contributor

@abdmmar abdmmar commented Mar 13, 2024

Description

Add CSS Variable to be able set top and right position for ModalPage component.

  • --modal-page-close-btn-right for setting close button right position, default to 32px
  • --modal-page-close-btn-top for setting close button top position, default to 32px

Since we already have top and right position, setting position using margin is unnecessary

Usage

In the application, we can redeclare the CSS Variable like this:

.modal {
  --modal-page-close-btn-top: 50px
}

@abdmmar abdmmar changed the title fix(ModalPage): add css variable to set top and right position #minor fix(ModalPage): add css variable to set top and right position Mar 13, 2024
@rayhan-ab
Copy link
Collaborator

if it's a fix, shouldn't it be #patch instead of #minor?

@rayhan-ab rayhan-ab merged commit 7dc6d70 into AccelByte:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants