Variable overrides in the notification profile and profile selection based on regular expressions #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, disabling health checks
fusiondog
pushed a commit
that referenced
this pull request
Mar 2, 2017
* Initial implementation of the mattermost notifier * Remove unused code * Define host * sprintf(), not printf() * Forgot to add the MatterMostUserInfo struct * userID, not userId * Define initialized property * Remove unusded variables * Specify variable type * Fill in the unfilled * Fat fingered struct * Rename TeamName to Taam - Makes more sense * Update version string * Only parse for port if specified * Fix URL parsing * Remove some debugging statements * log.Fatal -> log.Error * Update the README file * Dramatically reduce unnecessary writes (PUT requests) to KV when no change in health check status. (#166) * Improve checking against blacklist by reducing the number of calls to KV. (#167) * Variable overrides in the notification profile and profile selection based on regular expressions (#164) * #145 notif-selection based on regular expressions is implemented * #145 use consul from vagrant for tests * #145 blacklisting services, nodes and checks by regexps implemented * #145 test for getProfileForEntity is simplified * #145 better explanation of regexps for profile activation, disabling health checks * #145 get rid of separate structs for keeping notifier configuration * #145 notifier names are constant per notifier type * #145 variable overrides in the notification profiles are implemented * #145 add go get command for imdario/mergo to travis * #145 re-add imdario/mergo to Godeps * #145 check that notifier exists before returning * #145 copy the notifier before overriding parameters * #145 use hashes of notifiers as keys in send-builtin * #145 remove debug print * Fix ID discrepency * do not trigger a notification if the new check is passing (#169) * Fixes return string for NotifierName() method on AwsSnsNotifier struct (#171) NotifName returns 'awsns' string and should return 'awssns' * Document Slack detailed config (#172) Added documentation for enabling Slack "detailed" notification mode. * Initial implementation of the mattermost notifier * Fix client to be a notifier property * s/MatterMost/Mattermost/g * ioutil is not needed * More of s/MatterMost/Mattermost/g * Add mattermost to notifiers struct * Implement Copy() method * Hardcode value for notifier name * Add enabled property to mattermost notifier struct * Remove fat fingered extra 't'
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of what we discussed in #145