Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve port handling #206

Merged
merged 1 commit into from
Feb 27, 2023
Merged

improve port handling #206

merged 1 commit into from
Feb 27, 2023

Conversation

xlc
Copy link
Member

@xlc xlc commented Feb 27, 2023

setupWithServer should not deal with env as it could be used as a library function

port could be zero which means let system to pick available port.

@xlc xlc requested a review from ermalkaleci February 27, 2023 09:16
}
argv.port = argv.port ?? (process.env.PORT ? Number(process.env.PORT) : 8000)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli overrides config file overrides env. maybe we want env to be top priority?

@xlc xlc enabled auto-merge (squash) February 27, 2023 09:22
@xlc xlc merged commit 38b7483 into master Feb 27, 2023
@xlc xlc deleted the improve-port branch February 27, 2023 09:37
ns212 pushed a commit to interlay/chopsticks that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants