Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pkg cache fail on windows, py<=2.7 #917

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

nerdvegas
Copy link
Contributor

fixes #912

@nerdvegas nerdvegas merged commit 213447a into master Aug 4, 2020
#
dev_stat_not_supported = (
platform.system() == "Windows" and
sys.version_info[:2] <= (2, 7)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually be < (3, 4) as this was only added in python 3.4: https://bugs.python.org/issue11939

@bpabel bpabel deleted the issue_912-pkgcache-win-nodev branch January 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package caching does not work on windows due to device not being implemented in py2 on Windows
2 participants