Improve install docs by mentioning how to actually download rez #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
changed the title
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
|
This is great !
|
|
I think the 2nd point of @MrLixm is quite important and should definitely be added :) The others seem more or less obvious to me as it kinda feels like basic knowledge that you would be expected to have as a developer. |
Signed-off-by: Jean-Christophe Morin <[email protected]>
|
Thank you @MrLixm and @parikshittiwari740! I pushed a new commit that I think addresses your feedback. Does the new changes look good to you? |
docs/source/installation.rst
Outdated
| To install rez, you will need: | ||
|
|
||
| 1. Python 3.7 or above. We support 3.7, 3.8, 3.9, 3.10 and 3.11. | ||
| The pythoon interpreter you use to run the install script will be the interpreter |
There was a problem hiding this comment.
@JeanChristopheMorinPerso Small typo
There was a problem hiding this comment.
Thanks. I'm a professional full time typo creator.
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
merged commit fb02c4a
into
AcademySoftwareFoundation:main
5 checks passed
JeanChristopheMorinPerso
added
the
openssf-best-practices
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
…emySoftwareFoundation#1660) Signed-off-by: Jean-Christophe Morin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://www.bestpractices.dev/en/projects/8389#interact.
I noticed that the docs were not very clear on how rez could be download.