-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "Caching" doc page #1615
New "Caching" doc page #1615
Conversation
…with new section that describes resolve caching. Signed-off-by: brycegbrazen <[email protected]>
Hi @brycegbrazen , thanks for creating this PR! Can you tell us what kind of help you would need? Some items to cover:
|
@JeanChristopheMorinPerso Honestly, everything you mentioned I don't know the answers to currently. I don't currently use resolve caching at my studio. If I end up filling this out it's going to be me piecing it together by just digging around in the code and making some educated guesses. I was just hoping someone who was familiar with, or using this feature could help out documenting it I suppose. |
Thanks. It's perfectly fine to not know the answers! If you want to dig in, we can give you hints for where to look at and help you understand how it all works. If not, then we could ask if someone would like to help with this. |
@JeanChristopheMorinPerso That's a great point. I can start by just asking in Slack if anyone is familiar with resolve caching and if they'd be willing to help add some documentation. If we don't hear back from anyone within a week or so I can just dig in myself. |
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Alright I've made a big sweeping update over everything. Hopefully this is enough to at least get this out the door. If there's anything else we want in here for this PR just let me know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a couple of comments that should be easy to address.
…working right now. Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the edits! Here is another batch of comments.
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
* Tweak caching docs a little bit to be more consistent with the other docs Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
Signed-off-by: brycegbrazen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @brycegbrazen and @predat! I think this is a good start and is ready to be merged.
24334d3
into
AcademySoftwareFoundation:main
With the help of @predat --------- Signed-off-by: brycegbrazen <[email protected]> Signed-off-by: Jean-Christophe Morin <[email protected]> Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
TODO:
Need more info on what exactly resolve caching is and how it works. We have a great big writeup for package caching, but prior to now we had no writeup for resolve caching. Would love some help with this new section.