RootNode API Changes #1931
Open
RootNode API Changes #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrbailey
requested review from
kmuseth,
apradhana,
jmlait,
Idclip and
richhones
as code owners
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
danrbailey
force-pushed
the
root_api_changes
branch
from
95de511
to
78b6d87
Compare
danrbailey
changed the base branch from
feature/drop_abi_9
to
feature/tree_api_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a number of changes to the RootNode. These methods are now part of the public API:
This new method is added - RootNode::deleteChildOrTile()
This introduces the ability to delete a child or tile from a RootNode. This was previously not possible, except for an unintuitive workaround by adding a background tile (which implicitly replaced the child or tile), then to erase all background tiles.
A bug was fixed in RootNode::setOrigin() where the origin was updated before the error was thrown allowing the user to catch the error and potentially leaving the root in an invalid and unsupported state.
Finally, I added a new RootNode unit test that added additional validation that wasn't previously being done and to confirm the changes in behaviour mentioned above. (Note this unit test is added using SPDX Apache-2.0 so #1928 needs to be merged first).