Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port OpenVDB Python bindings to nanobind and add NanoVDB Python bindings #1916

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Port OpenVDB Python bindings to nanobind and add NanoVDB Python bindings #1916

wants to merge 2 commits into from

Conversation

matthewdcong
Copy link
Contributor

No description provided.

@swahtz swahtz self-requested a review October 8, 2024 18:34
danrbailey
danrbailey approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@danrbailey danrbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, thanks @matthewdcong! I didn't do any user testing, but the implementation, build and CI changes all look reasonable to me. I just had one small question about which minimum version of nanobind we should support.

doc/dependencies.txt Outdated Show resolved Hide resolved
Idclip
Idclip approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Idclip Idclip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not runtime tested the changes. I have only reviewed the OpenVDB binding changes.

Can we please squash all commits into a single change? Or, better yet, a single commit which ports the OpenVDB bindings to nanobind, with a second commit to add the nanovdb bindings would be perfect. I'm happy with a single commit if necessary, I'm not sure the current commit chain is particularly useful.

Minor comments from me, looks good!

CMakeLists.txt Outdated Show resolved Hide resolved
ci/install_macos.sh Show resolved Hide resolved
openvdb/openvdb/python/CMakeLists.txt Show resolved Hide resolved
openvdb/openvdb/python/CMakeLists.txt Show resolved Hide resolved
openvdb/openvdb/python/pyMetadata.cc Show resolved Hide resolved
pendingchanges/nanobind.txt Show resolved Hide resolved
@matthewdcong matthewdcong force-pushed the openvdb_nanovdb_nanobind branch 2 times, most recently from 5d3707c to ee37791 Compare October 11, 2024 17:39
@matthewdcong
Copy link
Contributor Author

I have not runtime tested the changes. I have only reviewed the OpenVDB binding changes.

Can we please squash all commits into a single change? Or, better yet, a single commit which ports the OpenVDB bindings to nanobind, with a second commit to add the nanovdb bindings would be perfect. I'm happy with a single commit if necessary, I'm not sure the current commit chain is particularly useful.

Minor comments from me, looks good!

Thanks for the review! I will squash before merging. Delaying for now in case others have feedback in the meantime.

@matthewdcong
Copy link
Contributor Author

Waiting on #1933 to be merged in order to fix the Windows CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Idclip Idclip Idclip approved these changes

@danrbailey danrbailey danrbailey approved these changes

@kmuseth kmuseth Awaiting requested review from kmuseth kmuseth is a code owner

@apradhana apradhana Awaiting requested review from apradhana apradhana is a code owner

@jmlait jmlait Awaiting requested review from jmlait jmlait is a code owner

@richhones richhones Awaiting requested review from richhones richhones is a code owner

@swahtz swahtz Awaiting requested review from swahtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewdcong @Idclip @danrbailey