Don't update timestamp when regenerating instantation files. #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdumas
force-pushed
the
jdumas/cmake-timestamp
branch
2 times, most recently
from
4adb228
to
1b2084e
Compare
Signed-off-by: Jérémie Dumas <[email protected]>
jdumas
force-pushed
the
jdumas/cmake-timestamp
branch
from
1b2084e
to
740a69f
Compare
Idclip
approved these changes
Sep 24, 2023
danrbailey
approved these changes
Oct 24, 2023
Idclip
merged commit 99bbd41
into
AcademySoftwareFoundation:master
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
USE_EXPLICIT_INSTANTIATION=ON, re-running CMake will trigger recompilation of OpenVDB instantiation files. The culprit is the following line:openvdb/openvdb/openvdb/CMakeLists.txt
Line 601 in 3f8b6f3
As the documentation for file(WRITE) mentions, one should use configure_file() to copy generated files used as build sources, only if the content changes. Given that
USE_EXPLICIT_INSTANTIATIONwas created to save time when recompiling dependent files, this is quite an unfortunate mistake. This PR fixes that.