Remove deprecated argument to getChunkOffsetTableSize() #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cary Phillips <[email protected]>
|
@peterhillman, can you take a look at this? |
| @@ -442,7 +442,7 @@ bool usesLongNames (const Header &header); | |||
| // | |||
|
|
|||
| IMF_EXPORT | |||
| int getChunkOffsetTableSize(const Header& header,bool deprecated_attribute=false); | |||
| int getChunkOffsetTableSize(const Header& header); | |||
There was a problem hiding this comment.
Should the comment about the deprecated_attribute be removed (line 440) as well as the parameter itself?
Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Mar 28, 2021
* Remove deprecated argument to getChunkOffsetTableSize() Signed-off-by: Cary Phillips <[email protected]> * Remove mention of deprecated_attribute from comment Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #740 in time for the 3.0 release.
Signed-off-by: Cary Phillips [email protected]