Enable policy 77 if possible. #961
Conversation
When using OpenEXR as a submodule, you currently can't set a variable outside of it as the option will override it (so you need to set the option.) With policy 77 in place, this works as expected. Signed-off-by: Matthäus G. Chajdas <[email protected]>
There was a problem hiding this comment.
I was unfamiliar with this policy, https://cmake.org/cmake/help/latest/policy/CMP0077.html
Seems reasonable to me
|
What was the option for which you were having this trouble? |
|
I was trying to set |
|
I wonder if this also solves the issue I posted where I couldn't specify a CMAKE_INSTALL_PREFIX from the command line and get both OpenEXR and Imath to install there, when Imath is automatically installed by OpenEXR? OpenEXR goes to the right place, but Imath goes to the CMake default location. |
|
77 was introduced in cmake 3.13. Does it make sense to bump our minimum required to 3.13? (If we leave it at 3.12, are people likely to be frustrated and then spend time troubleshooting again, if they have a similar build issue?) |
|
@meshula I don't know about that, I'm using a local copy of Imath & OpenEXR without trying to pull in Imath via OpenEXR during |
|
I should mention here I had to add it in both OpenEXR and Imath locally to get it to work, see AcademySoftwareFoundation/Imath#119 -- it you want to bump to CMake 3.13, you really need to do it for both projects simultanously. |
|
See my comment AcademySoftwareFoundation/Imath#119 (comment) |
|
Progress note: Imath now installs into the correct place, without the policy modification, so that's unrelated to this issue. |
|
Thanks! |
When using OpenEXR as a submodule, you currently can't set a variable
outside of it as the option will override it (so you need to set the
option.) With policy 77 in place, this works as expected. See also: https://cmake.org/cmake/help/latest/policy/CMP0077.html
Signed-off-by: Matthäus G. Chajdas [email protected]