Resolve #882 static/shared dual build #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Feb 26, 2021
This was referenced Feb 26, 2021
cary-ilm
commented
Mar 10, 2021
| @@ -55,31 +55,19 @@ rd /s /q %BUILDTREE%\OpenEXR | |||
| mkdir %BUILDTREE%\OpenEXR | |||
| cd %BUILDTREE%\OpenEXR | |||
| cmake -G %cmake_platform% ^ | |||
| -DBUILD_ILMBASE_STATIC:BOOL=ON ^ | |||
| -DBUILD_BUILD_SHARED_LIBS:BOOL=OFF ^ | |||
There was a problem hiding this comment.
@meshula, looking at this again, shouldn't this be OPENEXR_BUILD_SHARED_LIBS, or just BUILD_SHARED_LIBS?
|
Oops! Glad you caught that before release :anime sweat drop: ! That was supposed to be OPENEXR_BUILD_SHARED_LIBS. Looking at our documentation, it says that we respect BUILD_SHARED_LIBS (a built in cmake variable), unless we've set OPENEXR_BUILD_SHARED_LIBS. Grepping the code I see references to BUILD_SHARED_LIBS. I think we should set another variable which peeks at both, and then refer to that derived variable throughout the code. I can take a pass this evening |
cary-ilm
added
Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cary Phillips [email protected]