Cherry-pick PR's into the RB-2.5 branch for v2.5.5 release #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arm64 macOS" This reverts commit 67053eb. Signed-off-by: Harry Mallon <[email protected]>
* In these types of builds we want arm64 and x86_64 (with AVX optimisations). However the way cmake works (with `CMAKE_OSX_ARCHITECTURES="arm64;x86_64"` means that we share one OpenEXRConfigInternal.h between both builds. So we have to have OPENEXR_IMF_HAVE_GCC_INLINE_ASM_AVX mean "AVX GCC asm is available if platform is x86", rather than "AVX GCC asm is available". Then we decide on AVX optimisations based on that #define and also the platform defines. Signed-off-by: Harry Mallon <[email protected]>
…undation#893) * Include <limits> where required by newer compilers Signed-off-by: Cary Phillips <[email protected]> * Removed redundant #include <limits> Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Peter Hillman <[email protected]>
Signed-off-by: Peter Hillman <[email protected]>
) * Use size_t for DWA buffersize calculation Signed-off-by: Peter Hillman <[email protected]> * use Int64 instead of size_t for buffersize calculations Signed-off-by: Peter Hillman <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
…emySoftwareFoundation#903) Signed-off-by: Peter Hillman <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
…ation#910) * update tileoffset sanitycheck to handle ripmaps Signed-off-by: Peter Hillman <[email protected]> * slight reorganization Signed-off-by: Peter Hillman <[email protected]> * slight reorganization Signed-off-by: Peter Hillman <[email protected]> * remove extra if statement from validateStreamSize Signed-off-by: Peter Hillman <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
) Signed-off-by: Peter Hillman <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
peterhillman
approved these changes
Feb 11, 2021
| char* _outBuffer; | ||
| Int64 _outBufferSize; | ||
| char* _planarUncBuffer[NUM_COMPRESSOR_SCHEMES]; | ||
| Int64 _planarUncBufferSize[NUM_COMPRESSOR_SCHEMES]; |
There was a problem hiding this comment.
Is it OK to change the memory layout of DwaCompressor for 32 bit systems between point releases? I assume it's OK, as the object isn't part of the API. I can imagine some horrific situation where a host application is linked against 2.2.4 but loads plugins linked against 2.2.5, and DwaCompressor object created by the 2.2.5 library gets passed to a 2.2.4 method.
(This should all be fine on systems where sizeof(size_t) == sizeof(Int64))
Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.