Fix stack corruption in Matrix tests #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Darby Johnston <[email protected]>
darbyjohnston
force-pushed
the
bugfix/matrix_test
branch
from
8feeba1 to
bb2afef
Compare
meshula
approved these changes
Aug 3, 2020
|
Sounds like an issue for the valgrind developers! Surprising such a simple overrun is undetected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was running the tests on Windows 10 with Visual Studio 2019 and getting this exception from ImathTest/testMatrix.cpp:
Run-Time Check Failure #2 - Stack around the variable 'm1' was corrupted.
It looks like this is coming from the M22 tests, there are two assignments that are out of bounds. I made a small fix and the test run now completes succesfully with no exceptions. Strangely I also tried running the test on CentOS 7 and did not get any exceptions, and even running it through Valgrind didn't turn up any errors, so I'm not quite sure what's going on there...