ImfChromaticities.cpp: Add back white to equality ops. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was discussed on openexr-dev and the unanimous conclusion was that white be added back; NB: no one could quite remember why it was omitted in the first place. See PR#651. IMPORTANT: This commit changes the existing behavior of the == and != operators so schedule its inclusion into the appropriate OpenEXR release. Signed-off-by: Arkell Rasiah <[email protected]>
|
Speak of the devil... I just realized its PR "666" |
cary-ilm
added
the
Needs Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed on openexr-dev and the unanimous conclusion was that white
be added back; NB: no one could quite remember why it was omitted in the first place.
See issue #651.
IMPORTANT: This commit changes the existing behavior of the == and != operators
so schedule its inclusion into an appropriate OpenEXR release.
Signed-off-by: Arkell Rasiah [email protected]