Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to fix broken Windows build. #641

Merged
merged 3 commits into from
Jan 25, 2020

Conversation

xlietz
Copy link
Contributor

@xlietz xlietz commented Jan 20, 2020

Signed-off-by: Christina Tempelaar-Lietz [email protected]

@xlietz xlietz requested a review from kdt3rd January 20, 2020 09:47
@xlietz
Copy link
Contributor Author

xlietz commented Jan 20, 2020

My change assumes that PyIlmBase requires both the Python interpreter and development components to exist. The Azure Windows builds were finding a version of Python3 on the Windows images that had the development component but not the interpreter. So Python3::Python was defined but Python3_EXECUTABLE was not, resulting in an error when pyilmbase_extract_rel_sitearch() was called.

(Note: I am still working on how to force it to using a specific version of python, rather than the versions it finds on the assigned Azure Windows node. If it was using the version being installed during CI, this error would probably not be triggered.)

Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christina -
If I read your comments about this correctly then this is perfect. Should we try to improve the error messages by then testing against the target and the Python2_Interpreter_FOUND variable to find which one is missing?

@xlietz
Copy link
Contributor Author

xlietz commented Jan 23, 2020

Yes I had thought about doing that! I'll make that change as soon as I can grab a minute.

Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
@xlietz xlietz merged commit f9229e9 into AcademySoftwareFoundation:master Jan 25, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
@xlietz xlietz deleted the ci-updates branch May 19, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants