Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warnings #479

Merged
merged 6 commits into from
Jul 23, 2019
Merged

Fix compile warnings #479

merged 6 commits into from
Jul 23, 2019

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Jul 22, 2019

This should make the tree compile cleanly with -Wall for both gcc 9 and clang 8

kdt3rd added 4 commits July 23, 2019 00:49
@kdt3rd
First pass of warning cleanup
01bcfdf 
This fixes g++ -Wall to compile warning free

Signed-off-by: Kimball Thurston <[email protected]>
@kdt3rd
Cleanup warnings for clang -Wall
7aa1548 
Signed-off-by: Kimball Thurston <[email protected]>
@kdt3rd
Ensure tests have assert when building in a release mode
341ef5f 
Fixes warnings and makes sure tests are ... testing

Signed-off-by: Kimball Thurston <[email protected]>
@kdt3rd
Fix issues and warnings compiling in optimized using gcc -Wall
285a628 
Signed-off-by: Kimball Thurston <[email protected]>
axxel
axxel reviewed Jul 22, 2019
View reviewed changes
OpenEXR/IlmImf/ImfFastHuf.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImfExamples/drawImage.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImfTest/testDeepScanLineMultipleRead.cpp Show resolved Hide resolved
OpenEXR/IlmImfTest/testBadTypeAttributes.cpp Show resolved Hide resolved
meshula
meshula reviewed Jul 22, 2019
View reviewed changes
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic bit of clean up, thanks!!

OpenEXR/IlmImf/ImfDeepScanLineInputFile.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImf/ImfMultiPartOutputFile.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImfExamples/lowLevelIoExamples.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImfExamples/rgbaInterfaceExamples.cpp Outdated Show resolved Hide resolved
OpenEXR/IlmImfFuzzTest/testFuzzDeepScanLines.cpp Outdated Show resolved Hide resolved
cary-ilm
cary-ilm reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to the comments.

@kdt3rd kdt3rd merged commit 625b95f into AcademySoftwareFoundation:master Jul 23, 2019
@kdt3rd kdt3rd deleted the fix_compile_warnings branch July 23, 2019 10:09
@cary-ilm cary-ilm added this to the v2.4.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cary-ilm cary-ilm cary-ilm left review comments

@axxel axxel axxel left review comments

@meshula meshula meshula left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kdt3rd @meshula @axxel @cary-ilm