Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added missing files in autoconf setup #444

Merged

Conversation

cary-ilm
Copy link
Member

Added IlmThreadSemaphoreOSX to IlmBase/IlmThread/Makefile.am and added PyIlmBase/PyIlmBase.pc.in back in, looks like it got inadvertently removed by a previous commit.

Signed-off-by: Cary Phillips [email protected]

…d PyIlmBase/PyIlmBase.pc.in back in, looks like it got inadvertently removed by a previous commit.

Signed-off-by: Cary Phillips <[email protected]>
Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Only comment I have is that on a related note, PyIlmBase autoconf generates a PyIlmBaseConfig.h but doesn't use that header or any of the defines in it, we can probably remove that from the autoconf for PyIlmBase?

@cary-ilm
Copy link
Member Author

I'll look into eliminating PyIlmBaseConfig.h.

@cary-ilm cary-ilm merged commit c580d35 into AcademySoftwareFoundation:master Jul 17, 2019
@cary-ilm cary-ilm added this to the v2.4.0 milestone Aug 10, 2019
@cary-ilm cary-ilm deleted the cmake-missing-files branch October 20, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants