Use core compression #1743
Merged
Use core compression #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to have a context without having to actually have a file (i.e. to use a header object in the C++ layer, or compression) Signed-off-by: Kimball Thurston <[email protected]>
This will conflict with main, but is easier to test exact matches with getting the compression options inline with both libraries Signed-off-by: Kimball Thurston <[email protected]>
This will allow users of the pipeline to run the compression / decompression, and to replace the C++ compressor utilities. This also adds some additional checks and looser memory restrictions to the decompression scheme for ease when we don't have all the information needed for encoding / decoding. Signed-off-by: Kimball Thurston <[email protected]>
This makes construction consistent with core, where by once constructed, the object is ready to be used. (file is opened and parsed or ready for population) Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Not all compilers coerce the types to the same Signed-off-by: Kimball Thurston <[email protected]>
not all compilers have named vararg macros yet Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
Signed-off-by: Kimball Thurston <[email protected]>
|
On the Bazel side I get a several of those errors here:
|
Previous commits had tried to reduce the number of calls to chunk offset but that prevented updates during partial header changes Signed-off-by: Kimball Thurston <[email protected]>
yeah, the same thing was happening on the mainline build too, I had been too focused on fixing oss-fuzz failures to re-run the normal tests before pushing |
Signed-off-by: Kimball Thurston <[email protected]>
kdt3rd
merged commit 6493af2
into
AcademySoftwareFoundation:staging/cpp_core_rewrite
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the C++ compression classes to use the core compression