Allow partial chunk tables #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimball Thurston <[email protected]>
This will fix AcademySoftwareFoundation#1642, re-enabling partial chunk tables during reconstruction (at least for the last part read). Correctly handles reconstructing tables where discovered tiles are shifted from expected indices Signed-off-by: Kimball Thurston <[email protected]>
lgritz
approved these changes
Mar 2, 2024
|
Should we be worried about the fuzz test fail? |
oh, probably. it is failing square in where I was changing behaviour, but is not part of the standard tests... |
When reconstructing chunk table with corrupt chunks, avoid writing out of bounds Signed-off-by: Kimball Thurston <[email protected]>
unaligned reads are UB, use (__builtin_) memcpy Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2024
* fix sporadic UB in dwa Signed-off-by: Kimball Thurston <[email protected]> * Allow partial chunk tables This will fix AcademySoftwareFoundation#1642, re-enabling partial chunk tables during reconstruction (at least for the last part read). Correctly handles reconstructing tables where discovered tiles are shifted from expected indices Signed-off-by: Kimball Thurston <[email protected]> * Avoid OOB write When reconstructing chunk table with corrupt chunks, avoid writing out of bounds Signed-off-by: Kimball Thurston <[email protected]> * avoid undefined behavior unaligned reads are UB, use (__builtin_) memcpy Signed-off-by: Kimball Thurston <[email protected]> --------- Signed-off-by: Kimball Thurston <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 4, 2024
* fix sporadic UB in dwa Signed-off-by: Kimball Thurston <[email protected]> * Allow partial chunk tables This will fix #1642, re-enabling partial chunk tables during reconstruction (at least for the last part read). Correctly handles reconstructing tables where discovered tiles are shifted from expected indices Signed-off-by: Kimball Thurston <[email protected]> * Avoid OOB write When reconstructing chunk table with corrupt chunks, avoid writing out of bounds Signed-off-by: Kimball Thurston <[email protected]> * avoid undefined behavior unaligned reads are UB, use (__builtin_) memcpy Signed-off-by: Kimball Thurston <[email protected]> --------- Signed-off-by: Kimball Thurston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1642, re-enabling partial chunk table reconstruction and processing.