Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in README.md #1575

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix typo in README.md #1575

merged 2 commits into from
Oct 10, 2023

Conversation

barnabyrobson
Copy link
Contributor

change make -> cmake

@barnabyrobson
fix typo in README.md
e0d761b 
change make -> cmake

Signed-off-by: Barnaby Robson <[email protected]>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

cary-ilm
cary-ilm approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kmilos
kmilos reviewed Oct 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@barnabyrobson
removes mkdir.
a45afc6 
Suggested by Milos in review. I tested it and it works.

Signed-off-by: Barnaby Robson <[email protected]>
@cary-ilm
Copy link
Member

Perfect, thanks for the fix!

@cary-ilm cary-ilm merged commit a3b46d5 into AcademySoftwareFoundation:main Oct 10, 2023
@barnabyrobson barnabyrobson deleted the brobson_fix_documentation branch October 12, 2023 23:01
annguyen-ilm pushed a commit to annguyen-ilm/openexr that referenced this pull request Oct 24, 2023
@barnabyrobson @annguyen-ilm
fix typo in README.md (AcademySoftwareFoundation#1575)
4c0c49e 
* fix typo in README.md

change make -> cmake

Signed-off-by: Barnaby Robson <[email protected]>

* removes mkdir.

Suggested by Milos in review. I tested it and it works.

Signed-off-by: Barnaby Robson <[email protected]>

---------

Signed-off-by: Barnaby Robson <[email protected]>
Signed-off-by: An Nguyen <[email protected]>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Feb 13, 2024
@barnabyrobson @cary-ilm
fix typo in README.md (AcademySoftwareFoundation#1575)
0b6459b 
* fix typo in README.md

change make -> cmake

Signed-off-by: Barnaby Robson <[email protected]>

* removes mkdir.

Suggested by Milos in review. I tested it and it works.

Signed-off-by: Barnaby Robson <[email protected]>

---------

Signed-off-by: Barnaby Robson <[email protected]>
@cary-ilm cary-ilm mentioned this pull request Feb 14, 2024
Merged
cary-ilm pushed a commit that referenced this pull request Feb 16, 2024
@barnabyrobson @cary-ilm
fix typo in README.md (#1575)
d9360a6 
* fix typo in README.md

change make -> cmake

Signed-off-by: Barnaby Robson <[email protected]>

* removes mkdir.

Suggested by Milos in review. I tested it and it works.

Signed-off-by: Barnaby Robson <[email protected]>

---------

Signed-off-by: Barnaby Robson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmilos kmilos kmilos left review comments

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnabyrobson @cary-ilm @kmilos