fix build of 2.5 branch with GCC 13 #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
explictly include <cstdint> Signed-off-by: Martin Aumüller <[email protected]>
meshula
approved these changes
Jul 29, 2023
|
Are we just merging this because why not, or are we considering a 2.5.x release? That's a branch that we don't claim to support and haven't updated (even for critical fixes) for a over 2 years. |
|
@aumuell, do you have a specific need for a 2.5 patch release? We don't actively maintain 2.x releases, but if you do have a specific need we can discuss it. |
|
The OpenEXR I/O plugin of OpenSceneGraph uses the version 2 API. And OpenSceneGraph does not seem to get updates any longer. This is why I built this old branch of OpenEXR. |
|
That's fine, I'll merge the change and put out a new 2.5.9 release. |
|
Done. |
|
Thank you for applying this and the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explicitly including
<cstdint>at three locations is sufficient